[Webkit-unassigned] [Bug 32753] REGRESSION(52325) Chromium build broken due to link failure

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=32753





--- Comment #1 from Peter Kasting <pkasting at google.com>  2009-12-18 16:12:38 PST ---
Edited IRC log for posterity:

<pkasting> othermaciej mentioned the idea of adding a config.h for this section
of the project and just having it #include Platform.h
<othermaciej> WebCore and JavaScriptCore have a rule that config.h must be the
first include in every file
<othermaciej> it seems reasonable to me to do that for WebKit too
<eseidel> sounds like othermaciej's idea is a good one, as usual :)
<eseidel> I think the utility of a non-PCH build has not at least historically
been well understood
<eseidel> with XCode eventually moving to distcc 3, everyone will want a
non-PCH build eventually
<pkasting> So is the resolution here that we should, in fact, add a config.h to
WebKit, have it #include Platform.h, and add #include config.h to all the
source files?
<eseidel> I would just add it to the files you need to un-break the build
<eseidel> and we can let webkit.org bake on that policy for a while
<eseidel> I think it's important to un-break the build, but we can figure out
what the final full-scale policy change looks like later

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.