[Webkit-unassigned] [Bug 32753] New: REGRESSION(52325) Chromium build broken due to link failure

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=32753

           Summary: REGRESSION(52325) Chromium build broken due to link
                    failure
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Mac OS X 10.5
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: New Bugs
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: eric at webkit.org
                CC: mjs at apple.com, sam at webkit.org, pkasting at google.com


REGRESSION(52325) Chromium build broken due to link failure

http://build.chromium.org/buildbot/waterfall.fyi/builders/Webkit%20Mac%20(webkit.org)/builds/11702/steps/compile/logs/stdio

Ld
/b/slave/webkit-rel-mac-webkit-org/build/src/webkit/tools/test_shell/../../../xcodebuild/Release/test_shell_tests
normal i386
    cd /b/slave/webkit-rel-mac-webkit-org/build/src/webkit/tools/test_shell
    setenv MACOSX_DEPLOYMENT_TARGET 10.5
    /Developer/usr/bin/g++-4.2 -arch i386
[snip]
Undefined symbols:
  "_wkNoteOpenPanelFiles", referenced from:
      _wkNoteOpenPanelFiles$non_lazy_ptr in libwebcore.a(WebSystemInterface.o)
  "_WKNoteOpenPanelFiles", referenced from:
      _WKNoteOpenPanelFiles$non_lazy_ptr in libwebcore.a(WebSystemInterface.o)
ld: symbol(s) not found

The failure does not occur on the webkit.org builders yet, because it doesn't
link against anything yet.

The solution is to include platform.h from WebSystemInterface.m to make sure
that we get the right symbol on Leopard.

I'm going to make a quick-and-dirty include platform.h fix.  Eventually we
might wish to use a config.h wrapper around platform.h instead.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.