[Webkit-unassigned] [Bug 32487] [check-webkit-style] cpp_style.py contains code redundant with check-webkit-style

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Dec 13 03:48:54 PST 2009


https://bugs.webkit.org/show_bug.cgi?id=32487





--- Comment #1 from Chris Jerdonek <chris.jerdonek at gmail.com>  2009-12-13 03:48:53 PST ---
Created an attachment (id=44752)
 --> (https://bugs.webkit.org/attachment.cgi?id=44752)
Proposed patch

Some of the changes:

- Eliminated obsolete main() and _USAGE from cpp_style.py.
- Moved cpp_style.py's file documentation to check-webkit-style.
- Added default values to _USAGE string in check-webkit-style.
- Added the default filter values to the --filter= output.
- Made style categories a list rather than a string.
- Moved _WEBKIT_FILTER to be near the other global constants.
- Renamed _DEFAULT_FILTERS to be consistent with --filter and _WEBKIT_FILTER.
- Renamed two "print_" methods to "exit_with_" since they exit.
- Cleaned up other minor issues.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list