[Webkit-unassigned] [Bug 32487] [check-webkit-style] cpp_style.py contains code redundant with check-webkit-style

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=32487


Chris Jerdonek <chris.jerdonek at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #44752|0                           |1
        is obsolete|                            |
  Attachment #44759|                            |review?
               Flag|                            |




--- Comment #2 from Chris Jerdonek <chris.jerdonek at gmail.com>  2009-12-13 12:34:38 PST ---
Created an attachment (id=44759)
 --> (https://bugs.webkit.org/attachment.cgi?id=44759)
Proposed patch 2

Tweaked previous patch:

- Changed double quotes to single quotes in _STYLE_CATEGORIES.
- Also changed global "FILTER" references to "FILTER_RULES".
  This is because there was confusion in using "filter" to refer 
  both to an individual filter rule (e.g. "+foo") as well as to
  the filter resulting from a list of such rules (a filter 
  being a list of filters).  Instead I chose to use "filter" for 
  the collective rule and "filter rule" for the individual 
  boolean rules making up a filter.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.