[Webkit-unassigned] [Bug 32406] [bzt] Convert rollout to StepSequence

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=32406





--- Comment #4 from Adam Barth <abarth at webkit.org>  2009-12-11 12:49:38 PST ---
Basically, instead of caching the patch object on the step, we carry a "state"
dictionary along while running the steps.  Various steps can read or write this
state dictionary as appropriate.

In this case, Rollout kicks adds the revision number to the state so that the
ApplyReverseDiffStep can know what revision to revert.  This system also let's
us carry the commit_text from CommitStep to ClosePatchStep, letting us remove
the last piece of custom logic in the LandingSequence.

Finally, instead of making RolloutStep a one-off, I generalized it with
MetaStep that lets you aggregate a bunch of smaller steps together into a
bigger step.  This is needed because RolloutStep wants to check for
--complete-rollout before building or committing.  We could have taught
BuildStep and CommitStep about --complete-rollout, but that didn't seem to be
the right layer of abstraction...

We can discuss further if you like.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.