[Webkit-unassigned] [Bug 32406] [bzt] Convert rollout to StepSequence

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=32406





--- Comment #5 from Eric Seidel <eric at webkit.org>  2009-12-11 14:42:02 PST ---
(From update of attachment 44663)
Why is {} necessary here?  it seems wrong:
 270         EnsureBuildersAreGreenStep(tool, options).run({})

run should have a default arguemtn of None, and then if passed None should use
a {}

It seems that would require step to have a base-class "run" wrapper which knew
how to call some _run_internal with the proper args.  not sure.  I also wonder
if the various run methods shouldn't return some dictionary instead, which the
wrapping run() call could use to update the existing dictionary.  That makes it
easier to test the inputs/outputs of the various run internal functions, no?

I shoudl fix this:
log("\nNOTE: Rollout support is experimental.\nPlease verify the rollout diff
and use \"bugzilla-tool land-diff %s\" to commit the rollout." % bug_id)
it's actually better to just re-run rollout with --complete-rollout and
--force-clean

I think this whole thing could have been done in smaller pieces, by first
moving some of the Rollout stuff into steps, and then dealing with the separate
state question.

I think MetaStep is useful.  StepSequence could be written on top of it, or
MetaStep could use StepSequence.  Either way they should share code.

I think it makes the most sense for MetaStep to just have a step sequence as an
member and use that.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.