[Webkit-unassigned] [Bug 24300] Add CSSKeepVisitedLinksPrivate option to WebCore

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=24300





--- Comment #42 from robert <robert at roberthogan.net>  2009-12-07 11:10:25 PST ---
(In reply to comment #41)
> (From update of attachment 44364 [details])
> > @@ -873,7 +873,11 @@ CSSStyleSelector::SelectorChecker::SelectorChecker(Document* document, bool stri
> >      , m_collectRulesOnly(false)
> >      , m_pseudoStyle(NOPSEUDO)
> >      , m_documentIsHTML(document->isHTMLDocument())
> > +    , m_cssVisitedStyleEnabled(true)
> 
> In a class named CSSStyleSelector, it seems that include "css" in the name of
> the data member is not helpful. The best boolean data member names are things
> that complete a phrase "style selector <xxx>" so I would call this
> m_ignoresVisitedLinks.
> 
>From comment #34:
> Also m_ignoreVisitedLinks
> isn't the greatest name.  We're not ignoring visited links.  We're ignoring the
> history for the purpose of computing the :visited pseud-selector.
:-) I think you read that comment and are disagreeing with Adam - so I'll
change it back again if no one still objects.. or let me know.

> I'm also not sure the CSS style selector is the right level for this. The
> PageGroup class already has a function setShouldTrackVisitedLinks. Do we really
> need to add something else?
> 
I should have mentioned in the original bug report that I decided against this
because the purpose of the setting is to conceal visited links from CSS
exploits rather than not track visited links at all (and wipe from the hash db
any already visited). This seemed the less intrusive way of implementing it,
since the user may find it confusing when they switch *out* of the option and
find that links which were displayed as visited before they switched are now
displayed as not-visited.


> I'm going to say review- for now so you can consider both of those comments.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.