[Webkit-unassigned] [Bug 24300] Add CSSKeepVisitedLinksPrivate option to WebCore

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=24300


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #44364|review?                     |review-
               Flag|                            |




--- Comment #41 from Darin Adler <darin at apple.com>  2009-12-07 09:59:43 PST ---
(From update of attachment 44364)
> @@ -873,7 +873,11 @@ CSSStyleSelector::SelectorChecker::SelectorChecker(Document* document, bool stri
>      , m_collectRulesOnly(false)
>      , m_pseudoStyle(NOPSEUDO)
>      , m_documentIsHTML(document->isHTMLDocument())
> +    , m_cssVisitedStyleEnabled(true)

In a class named CSSStyleSelector, it seems that include "css" in the name of
the data member is not helpful. The best boolean data member names are things
that complete a phrase "style selector <xxx>" so I would call this
m_ignoresVisitedLinks.

I'm also not sure the CSS style selector is the right level for this. The
PageGroup class already has a function setShouldTrackVisitedLinks. Do we really
need to add something else?

I'm going to say review- for now so you can consider both of those comments.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.