[Webkit-unassigned] [Bug 28808] [Skia] Fix flaky layout test svg/dynamic-updates/SVGClipPathElement-dom-clipPathUnits-attr.html [DEBUG]

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28808





--- Comment #4 from Roland Steiner <rolandsteiner at google.com>  2009-08-31 05:15:38 PDT ---
(In reply to comment #3)
> (From update of attachment 38733 [details])
> [...]
> Not sure why you're moving the inline functions around... I guess so you can
> export a function?

Yes, I needed to move the relevant functions out of the anonymous namespace,
but wanted to retain it for the generically named 'fastMod' and 'square'
functions.

> If we're going to export the function we should just add it to a header no?  Or
> to some utility file?

Well, since the comment on those functions was that they should go away sooner
or later I didn't want to give them additional exposure. (I don't know what
would happen to this patch at that point, though.) Also, a short'n'simple
'extern' was sufficient for my purposes so I left it at that.

But if you think it'd still be worthwhile I could certainly add them to some
header file.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.