[Webkit-unassigned] [Bug 28808] [Skia] Fix flaky layout test svg/dynamic-updates/SVGClipPathElement-dom-clipPathUnits-attr.html [DEBUG]

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28808


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #38733|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #3 from Eric Seidel <eric at webkit.org>  2009-08-31 03:26:28 PDT ---
(From update of attachment 38733)
Looks fine.

+extern bool isPathSkiaSafe(const SkMatrix& transform, const SkPath& path);
should not have names for the arguments since they don't add anything.

Not sure why you're moving the inline functions around... I guess so you can
export a function?

If we're going to export the function we should just add it to a header no?  Or
to some utility file?

This looks OK.  Waiting for your response or new patch before landing.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.