[Webkit-unassigned] [Bug 28040] commit-queue needs a master process

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28040





--- Comment #10 from Eric Seidel <eric at webkit.org>  2009-08-27 14:52:45 PDT ---
(In reply to comment #9)
> (From update of attachment 38637 [details])
> +            self._run_command(['bugzilla-tool', 'land-patches',
> '--force-clean', '--commit-queue', '--quiet', bug_id])
> 
> This seems to require bugzilla-tool to be in your path.  We should use our get
> webkit script path routine here.

Nah, fixed using __FILE__.  We want to execute the exact same script as we're
currently executing, no matter where it may be.

> +            bug_id = bug_ids[0]
> 
> I'm worried we could get stuck in a loop processing bug zero.  Can't we
> restructure this loop so we go through all the bugs in the queue?  Also, we
> should put everything in the try-catch to avoid dieing on exceptions.

Yup, we could get stuck.  I don't think we should try and handle that case. 
The commit-queue is a remotely stored queue.  We shouldn't be trying to work
around possible bugs in updating that queue.  If it gets stuck, someone will
fix the bug which caused it to get stuck. ;)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.