[Webkit-unassigned] [Bug 28040] commit-queue needs a master process

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 26 19:38:41 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=28040


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #38637|review?                     |review-
               Flag|                            |




--- Comment #9 from Adam Barth <abarth at webkit.org>  2009-08-26 19:38:41 PDT ---
(From update of attachment 38637)
+            self._run_command(['bugzilla-tool', 'land-patches',
'--force-clean', '--commit-queue', '--quiet', bug_id])

This seems to require bugzilla-tool to be in your path.  We should use our get
webkit script path routine here.

+            bug_id = bug_ids[0]

I'm worried we could get stuck in a loop processing bug zero.  Can't we
restructure this loop so we go through all the bugs in the queue?  Also, we
should put everything in the try-catch to avoid dieing on exceptions.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list