[Webkit-unassigned] [Bug 28725] resolve-ChangeLogs: determineVCSRoot() returns incorrect repository root during git filter-branch

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28725





--- Comment #4 from David Kilzer (ddkilzer) <ddkilzer at webkit.org>  2009-08-26 09:18:26 PDT ---
(In reply to comment #3)
> The intent is good, but it seems a bit hacky to special-case git filter-branch.
>  If resolve-changelogs still works when you don't need the repository root in
> this particular case, it seems like you could just make it generally work in
> that way and remove the special casing.  (Maybe just always chdir to the `git
> rev-parse --show-cdup` at startup?)  But I know nothing about this program so
> please take it as a suggestion and don't let my sniping block your commit.

No, it needs to be special-cased.  See the explanation in Comment #0 or the
ChangeLog entry.

The code that changed directories to the repository root was added for Bug
18599.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.