[Webkit-unassigned] [Bug 28725] resolve-ChangeLogs: determineVCSRoot() returns incorrect repository root during git filter-branch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 26 09:07:35 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=28725





--- Comment #3 from Evan Martin <evan at chromium.org>  2009-08-26 09:07:34 PDT ---
The intent is good, but it seems a bit hacky to special-case git filter-branch.
 If resolve-changelogs still works when you don't need the repository root in
this particular case, it seems like you could just make it generally work in
that way and remove the special casing.  (Maybe just always chdir to the `git
rev-parse --show-cdup` at startup?)  But I know nothing about this program so
please take it as a suggestion and don't let my sniping block your commit.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list