[Webkit-unassigned] [Bug 28131] [Haiku] Adding font-specific files to WebCore.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28131





--- Comment #29 from Maxime Simon <simon.maxime at gmail.com>  2009-08-25 03:17:15 PDT ---
(In reply to comment #28)
> (From update of attachment 38538 [details])
> For the sake of those of us who aren't familiar with haiku, make the
> font_family argument to findMatchingFontFamily a pointer, and dereference
> appropriately. 

I tried, but it "segfault" when making str(n)py(*family…);

> Also replace all uses of strcpy with strncpy (never use strcpy
> -- most modern analysis tools will flag any use of strcpy as being bad).

I used strncpy for the copy which may be "dangerous". Should I do the same even
if the source string is known (and will not exceed 64)?

> I don't know haiku idioms but
> m_font->SetFamilyAndStyle(fontFamily, 0);
> seems superfluous as it's immediately followed by
> m_font->SetFamilyAndStyle(fontFamily, *fontStyle);

Strange, I thought I passed m_font to findMatchingFontStyle(), but in fact not.
So indeed this should be removed. :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.