[Webkit-unassigned] [Bug 28131] [Haiku] Adding font-specific files to WebCore.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28131


Oliver Hunt <oliver at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #38538|review?                     |review-
               Flag|                            |




--- Comment #28 from Oliver Hunt <oliver at apple.com>  2009-08-25 03:03:17 PDT ---
(From update of attachment 38538)
For the sake of those of us who aren't familiar with haiku, make the
font_family argument to findMatchingFontFamily a pointer, and dereference
appropriately.  Also replace all uses of strcpy with strncpy (never use strcpy
-- most modern analysis tools will flag any use of strcpy as being bad).

I don't know haiku idioms but
m_font->SetFamilyAndStyle(fontFamily, 0);
seems superfluous as it's immediately followed by
m_font->SetFamilyAndStyle(fontFamily, *fontStyle);

Fix those up and it will be good.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.