[Webkit-unassigned] [Bug 28670] [Chromium] Multi-value select boxes cannot do non-contiguous selection

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28670





--- Comment #6 from Robert Sesek <rsesek at bluestatic.org>  2009-08-24 05:28:47 PDT ---
(In reply to comment #5)
> Mechanically that's OK, but it's not exactly the right concept.
> PLATFORM(DARWIN) is really supposed to be an OS-level switch like
> PLATFORM(WINOS) that tells you what low level OS is on the target machine.
> PLATFORM(DARWIN) means Apple's Unix variant with things like frameworks and
> certain libraries expected to be installed.
> 
> This seems to be more about which style of user interface we want. Chromium
> creates a non-Mac platform that wants to follow Mac user interface style
> because while it's virtual it is on a Mac.
> 
> To make that clear I think we'll probably need a different macro in the long
> run. Short run, we might be OK saying PLATFORM(DARWIN) here unless there's some
> other port running with PLATFORM(DARWIN) defined that doesn't want this
> behavior. For example, it's not too farfetched to imagine trouble if you were
> compiling for QT or GTK on a Mac.

Then to be on the safe side, I think the answer is to use, like we do earlier
in the same file, PLATFORM(MAC) || (PLATFORM(CHROMIUM) && PLATFORM(DARWIN)).
>From what I've discovered on mailing lists, PLATFORM(MAC) is used pretty much
for Safari on OS X. Perhaps the right answer long-term is to make a
PLATFORM(SAFARI) so that PLATFORM(MAC) can be used in instances like this.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.