[Webkit-unassigned] [Bug 28670] [Chromium] Multi-value select boxes cannot do non-contiguous selection

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28670





--- Comment #5 from Darin Adler <darin at apple.com>  2009-08-23 22:13:23 PDT ---
(In reply to comment #4)
> We use at the top of the file:
> 
> #if PLATFORM(MAC) || (PLATFORM(CHROMIUM) && PLATFORM(DARWIN))
> 
> I spoke to Jeremy about hit and he thought we could reduce it to just
> PLATFORM(DARWIN).

Mechanically that's OK, but it's not exactly the right concept.
PLATFORM(DARWIN) is really supposed to be an OS-level switch like
PLATFORM(WINOS) that tells you what low level OS is on the target machine.
PLATFORM(DARWIN) means Apple's Unix variant with things like frameworks and
certain libraries expected to be installed.

This seems to be more about which style of user interface we want. Chromium
creates a non-Mac platform that wants to follow Mac user interface style
because while it's virtual it is on a Mac.

To make that clear I think we'll probably need a different macro in the long
run. Short run, we might be OK saying PLATFORM(DARWIN) here unless there's some
other port running with PLATFORM(DARWIN) defined that doesn't want this
behavior. For example, it's not too farfetched to imagine trouble if you were
compiling for QT or GTK on a Mac.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.