[Webkit-unassigned] [Bug 28669] make-script-test-wrappers should be executable

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28669





--- Comment #6 from Cameron McCormack <cam at mcc.id.au>  2009-08-24 00:38:47 PDT ---
(In reply to comment #5)
> As with newly-added files we could consider pre-adding a comment to the
> generated file to say what the change is. For example, changing the state of
> the executable flag is one of the most common changes and it would be good to
> do it automatically.
> 
> On the flip side, when changing flags on tons of files, having a list of the
> files with flags changed is probably not helpful in the way that listing files
> with contents changed is in typical patches. I have a slight fear that we'll
> have change log entries that are largely vacuous. Contributors don't seem to
> treat the change log as a communication tool as much as I'd like; those lists
> of files and functions are supposed to be for human consumption, and folks
> should read them and change anything that does not seem helpful.
> 
> But yes, that would be a nice thing to fix.

Filed https://bugs.webkit.org/show_bug.cgi?id=28675 for this.

Agreed with the chance for creating large, useless ChangeLog entries, but
hopefully contributors will use common sense and pare them down if necessary.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.