[Webkit-unassigned] [Bug 28669] make-script-test-wrappers should be executable

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28669





--- Comment #5 from Darin Adler <darin at apple.com>  2009-08-23 22:23:54 PDT ---
(In reply to comment #4)
> (In reply to comment #3)
> > Right, it doesn't consider property changes as something it should list in the
> > change log.
> 
> Should it?  It might make generating patches like this one easier if
> prepare-ChangeLog could be used.  If so, I can file a bug and supply a patch
> for prepare-ChangeLog if you like.

Sure, it would be OK.

As with newly-added files we could consider pre-adding a comment to the
generated file to say what the change is. For example, changing the state of
the executable flag is one of the most common changes and it would be good to
do it automatically.

On the flip side, when changing flags on tons of files, having a list of the
files with flags changed is probably not helpful in the way that listing files
with contents changed is in typical patches. I have a slight fear that we'll
have change log entries that are largely vacuous. Contributors don't seem to
treat the change log as a communication tool as much as I'd like; those lists
of files and functions are supposed to be for human consumption, and folks
should read them and change anything that does not seem helpful.

But yes, that would be a nice thing to fix.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.