[Webkit-unassigned] [Bug 27944] Geolocation error callback not called if permissions have already been denied

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27944


steveblock at google.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #34779|review?                     |
               Flag|                            |
  Attachment #34779|0                           |1
        is obsolete|                            |
  Attachment #38375|                            |review?
               Flag|                            |




--- Comment #2 from steveblock at google.com  2009-08-21 09:21:06 PDT ---
Created an attachment (id=38375)
 --> (https://bugs.webkit.org/attachment.cgi?id=38375)
Patch 2 for bug 27944

> We don't have a find method for this type?
I'm not aware of one that searches the value, rather than the key, of the map.

> Style:
Fixed

> No need to store it locally first:
Fixed

> Aren't the two if (isDenied()) blocks your editing identical?  Cant' we share
> code there?
Fixed

> Arguments are only named when the name adds clarity:
Fixed

> Who would know about this code?  I certainly don't.
It was written by Greg Bolsinga, but he's not a WebKit reviewer.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.