[Webkit-unassigned] [Bug 28463] config detects wrong version of libsoup

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28463


Jan Alonzo <jmalonzo at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jmalonzo at gmail.com




--- Comment #9 from Jan Alonzo <jmalonzo at gmail.com>  2009-08-20 15:59:23 PDT ---
(In reply to comment #5)
> (In reply to comment #4)
> > (In reply to comment #1)
> > > Forgot the patch? In any case the required version was bumped to 2.27.91.
> > 
> > Did you also rev the glib version ? Thats why I submitted a patch since you
> > need a newer glib also.
> 
> Well, the glib requirement is implicitly updated when we update the libsoup
> one, since you can't have libsoup installed otherwise.

We don't usually rely on implicit dependencies like these, or relying on
package managers to work out our minimum requirements.

> Groan if you turn on the new work to remove ICU you also need to rev pango and
> glib etc this version check is not good enough. You need to check for the GLIB
> version explicitly to support the unicode ICU removal work and libsoup.
> What version gets both ?
> 
> In  webkit.m4
> GLIB_REQUIRED_VERSION=2.0
> GOBJECT_REQUIRED_VERSION=2.0
> GTHREAD_REQUIRED_VERSION=2.0
> 
> PKG_CHECK_MODULES([GLIB],
>                   [glib-2.0 >= $GLIB_REQUIRED_VERSION
>                   gobject-2.0 >= $GOBJECT_REQUIRED_VERSION
>                   gthread-2.0 >= $GTHREAD_REQUIRED_VERSION])
> 
> This is probably not the correct version.

Agreed. I would be in favour of fixing this to reflect our actual requirements.

> Setting a build flag should not cause you to have to rebuild a ton of support
> libraries. And since your working with a late version of glib it makes a lot of
> sense to pick the compatible gtk/cairo etc libs. You don't have to but reving
> glib and pango and not reving gtk leads to a bit of a mess.

Patches welcome.

> Enough on this just it would be nice if all the version checks where reliable.
> Depending on secondary dependencies in support libraries to get the versions
> correct after you already checked is not a good idea.

I think we really have to be realistic with our requirements. Depending on
latest libsoup AND glib but leaving GTK behind is just a mess. I rather have
the dependencies in sync across the glib/gtk stack.

Again, patches welcome.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.