[Webkit-unassigned] [Bug 28463] config detects wrong version of libsoup

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28463





--- Comment #8 from Michael Emmel <mike.emmel at gmail.com>  2009-08-20 09:40:15 PDT ---
(In reply to comment #7)
> (In reply to comment #6)
> > (In reply to comment #5)
> > > (In reply to comment #4)
> > > > (In reply to comment #1)
> > > > > Forgot the patch? In any case the required version was bumped to 2.27.91.
> > > > 
> > > > Did you also rev the glib version ? Thats why I submitted a patch since you
> > > > need a newer glib also.
> > > 
> > > Well, the glib requirement is implicitly updated when we update the libsoup
> > > one, since you can't have libsoup installed otherwise.
> > 
> > Thats a tad fragile.
> > In configure
> 
> I don't see how, but we can update it (although I think it's kind of nice that
> those numbers show the minimum versions we need because of direct API usage
> from our side).
> 
> > 
> > GTK_REQUIRED_VERSION=2.10 
> > 
> > is probably not correct.
> 
> Why?

Groan if you turn on the new work to remove ICU you also need to rev pango and
glib etc this version check is not good enough. You need to check for the GLIB
version explicitly to support the unicode ICU removal work and libsoup.
What version gets both ?

In  webkit.m4
GLIB_REQUIRED_VERSION=2.0
GOBJECT_REQUIRED_VERSION=2.0
GTHREAD_REQUIRED_VERSION=2.0

PKG_CHECK_MODULES([GLIB],
                  [glib-2.0 >= $GLIB_REQUIRED_VERSION
                  gobject-2.0 >= $GOBJECT_REQUIRED_VERSION
                  gthread-2.0 >= $GTHREAD_REQUIRED_VERSION])

This is probably not the correct version.

Setting a build flag should not cause you to have to rebuild a ton of support
libraries. And since your working with a late version of glib it makes a lot of
sense to pick the compatible gtk/cairo etc libs. You don't have to but reving
glib and pango and not reving gtk leads to a bit of a mess.

Enough on this just it would be nice if all the version checks where reliable.
Depending on secondary dependencies in support libraries to get the versions
correct after you already checked is not a good idea.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.