[Webkit-unassigned] [Bug 27143] [Gtk][REGRESSION] XHR test failures after r45558

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27143


Jan Alonzo <jmalonzo at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|                            |FIXED




--- Comment #13 from Jan Alonzo <jmalonzo at gmail.com>  2009-08-20 06:43:21 PDT ---
(In reply to comment #12)
> (From update of attachment 35195 [details])
> > +    // The content-sniffed callback will handle the response if WebCore
> > +    // require us to sniff.
> > +    if(statusWillBeHandledBySoup(msg->status_code) || (!handle && handle->shouldContentSniff()))
> 
> This check is bogus. You should not check !handle, and then dereference it. As
> we discussed on IRC, you want this check as part of the outer 'or', possibly as
> the first one. Apart from this looks good, so r=me.

Patch updated prior to landing. Landed as
http://trac.webkit.org/changeset/47569.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.