[Webkit-unassigned] [Bug 27143] [Gtk][REGRESSION] XHR test failures after r45558

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27143


Gustavo Noronha (kov) <gns at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35195|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #12 from Gustavo Noronha (kov) <gns at gnome.org>  2009-08-20 06:28:57 PDT ---
(From update of attachment 35195)
> +    // The content-sniffed callback will handle the response if WebCore
> +    // require us to sniff.
> +    if(statusWillBeHandledBySoup(msg->status_code) || (!handle && handle->shouldContentSniff()))

This check is bogus. You should not check !handle, and then dereference it. As
we discussed on IRC, you want this check as part of the outer 'or', possibly as
the first one. Apart from this looks good, so r=me.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.