[Webkit-unassigned] [Bug 28449] [v8] Use atomic string caching for createElement

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28449





--- Comment #5 from Christian Plesner Hansen <christian.plesner.hansen at gmail.com>  2009-08-19 20:46:09 PDT ---
> > Index: WebCore/bindings/scripts/CodeGeneratorV8.pm
> 
> Why did this attribute change?

It's cleanup -- using V8Custom was a hack.  V8Custom is really there to
indicate that we have to use a customized implementation rather than a
generated accessor or function and using it for specifying atomic hints was a
bad idea in the first place.

> > Index: WebCore/bindings/scripts/IDLParser.pm
> > +                # Split arguments at commas but only if the comma
> > +                # is not within attribute brackets, expressed here
> > +                # as being followed by a ']' without a preceding '['.
> > +                # Note that this assumes that attributes don't nest.
> > +                my @params = split(/,(?![^[]*])/, $methodSignature);
> 
> I don't understand how this regex does what the comment says.
> 
> It looks like it splits on commas that are followed by anything except these
> three characters: '[', ']', '*'
> (using a negative width lookahead assertion).

The character class is closed by the first ']' so, using parens to indicate
precedence, it gets parsed as ((([^[])*)]) rather than ([^[]*]).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.