[Webkit-unassigned] [Bug 28449] [v8] Use atomic string caching for createElement

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28449


David Levin <levin at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35106|review?                     |review-
               Flag|                            |




--- Comment #4 from David Levin <levin at chromium.org>  2009-08-19 15:26:00 PDT ---
(From update of attachment 35106)

> Index: WebCore/bindings/scripts/CodeGeneratorV8.pm

Why did this attribute change?


> Index: WebCore/bindings/scripts/IDLParser.pm
> +                # Split arguments at commas but only if the comma
> +                # is not within attribute brackets, expressed here
> +                # as being followed by a ']' without a preceding '['.
> +                # Note that this assumes that attributes don't nest.
> +                my @params = split(/,(?![^[]*])/, $methodSignature);

I don't understand how this regex does what the comment says.

It looks like it splits on commas that are followed by anything except these
three characters: '[', ']', '*'
(using a negative width lookahead assertion).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.