[Webkit-unassigned] [Bug 28019] WINCE PORT: modified files in WebCore/storage

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 18 13:47:16 PDT 2009


--- Comment #18 from Jeremy Orlow <jorlow at chromium.org>  2009-08-18 13:47:15 PDT ---
(In reply to comment #17)
> (In reply to comment #16)
> > Why not just implement your own syncManager and have it work as you'd like it
> > to?
> Create another SyncManager is a cleaner option. But the point is sharing as
> much code as possible. I'm afraid some reviewers would suggest I share the same
> file.

What about this:

// License


void some function {


void more functions {



void multi-threaded function {


void more multi-threaded funcitons {



And then implement these in another file within storage/single_thread/blah.cpp
(or even in an #else statement below).

The biggest thing I'm against here is spaghetti code.  If it's between code
copying and spaghetti code we should DEFINITELY pick the former.  That said, I
think 75% of the #ifdefs can be eliminated by a couple tiny refactorings.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list