[Webkit-unassigned] [Bug 28019] WINCE PORT: modified files in WebCore/storage

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28019





--- Comment #17 from Yong Li <yong.li at torchmobile.com>  2009-08-18 13:41:18 PDT ---
(In reply to comment #16)

> 
> Here are some specific comments:

Reviewing is appreciated no matter you're reviewer or not. Thanks.

> 
> Is there anything in this file?  Maybe the above #if should say
> ENABLE(DOM_STORAGE) && !PLATFORM(WINCE) ?

Going to change this to ENABLE(SINGLE_THREADED) to make it help QtWebkit

> Why not just implement your own syncManager and have it work as you'd like it
> to?

Create another SyncManager is a cleaner option. But the point is sharing as
much code as possible. I'm afraid some reviewers would suggest I share the same
file.

> 
> How about making this a function somewhere.  isBackgroundThread.  This could be
> implemented either here or the StorageSyncManager.
> 
> The implementation for single threaded could just return true.  The normal
> implementation could be !isMainThread();
> 

> There's no need to make this inline.
> 
> It's a nit, but I don't see why markImported should be inlined here.  The mutex
> and condition could just be ifdef'ed off with no #else.
> 
> 
> Why are these necessary?  Since there's only one thread, wouldn't it always be
> on the main thread?
> 
> If it's absolutely necessary, it could be factored into a function like I
> mentioned above.

 good ideas. Thanks!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.