[Webkit-unassigned] [Bug 25406] -webkit-box-orient:horizontal doesn't work on <button> tag

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25406


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #34445|review?                     |review+, commit-queue+
               Flag|                            |




--- Comment #10 from Eric Seidel <eric at webkit.org>  2009-08-17 18:19:20 PDT ---
(From update of attachment 34445)
It's kinda evil... but really useful: webkit supports the window['id'] quirk
that IE implements.  So you could remove all of these lines:
8 var referenceHorizontalButton =
document.getElementById("reference_horizontal");
 9 var referenceVerticalButton = document.getElementById("reference_vertical");
 10 var defaultButton = document.getElementById("default");
 11 var horizontalButton = document.getElementById("horizontal");
 12 var verticalButton = document.getElementById("vertical");
 13 var toVerticalButton = document.getElementById("toVertical");
 14 var toHorizontalButton = document.getElementById("toHorizontal");

basically:
// <span id='foo'>
foo == getElementById('foo')
evaluates true in WebKIt and IE.  I'm nto sure about firefox.

Sometimes peopel also define a:
gebi() function to make things shorter:

function gebi(id) {
   return document.getElementById(id);
}

Technically a style violation:
 if (window.layoutTestController) {
 29     document.getElementById("main").innerHTML = "";
 30 }

Looks OK.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.