[Webkit-unassigned] [Bug 25406] -webkit-box-orient:horizontal doesn't work on <button> tag

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25406





--- Comment #9 from Shinichiro Hamaji <hamaji at chromium.org>  2009-08-10 04:07:35 PDT ---
> Is it possible to make a dumpAsText test for this instead?

Yes, it's possible. Thanks for the good catch!

> Should "isBox" be isFlexibleBox?

Agreed.

> Why shouldn't this check be moved inside createAnonymousBlock?
>  55         bool isBox = style()->display() == BOX || style()->display() ==
> INLINE_BOX;

RenderBlock::addChild() creates an anonymous child and call addChild() again
using the anonymous child when m_childrenInline is true. As RenderFlexibleBox's
m_childrenInline is always true, it means that creating an anonymous flexible
child causes infinite recursion (when addChild is called for a flexible box, it
creates an anonymous box, which is flexible, and it calls addChild for the
anonymous child. Then, the anonymous flexible child creates another anonymous
child and calls addChild again...). So, I think we need to control
flexible-ness of anonymous children in caller.

Thanks for the review. I hope my change looks better.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.