[Webkit-unassigned] [Bug 23727] Implementaion of WCSS marquee extension relevant to XHML MP

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=23727


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #34648|review+                     |review-
               Flag|                            |




--- Comment #31 from Eric Seidel <eric at webkit.org>  2009-08-12 15:15:14 PDT ---
(From update of attachment 34648)

 157     if (m_layer->renderer()->document()->isXHTMLMPDocument()) {
 158         if (m_timer.isActive() ||
m_layer->renderer()->style()->marqueeIncrement().isZero() ||
!m_layer->renderer()->style()->marqueeLoopCount())    
 159             return;
 160     } else {
 161         if (m_timer.isActive() ||
m_layer->renderer()->style()->marqueeIncrement().isZero())
 162             return;
 163     }
 164     

I would have written that as:

161         if (m_timer.isActive() ||
m_layer->renderer()->style()->marqueeIncrement().isZero() ||
(m_layer->renderer()->document()->isXHTMLMPDocument() &&
!m_layer->renderer()->style()->marqueeLoopCount())
 162             return;

in fact, that can seasily just be added as part of the existing if:

     if (m_timer.isActive() ||
m_layer->renderer()->style()->marqueeIncrement().isZero()
#if WCSS
|| (m_layer->renderer()->document()->isXHTMLMPDocument() &&
!m_layer->renderer()->style()->marqueeLoopCount()
#endif
}
156167         return;

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.