[Webkit-unassigned] [Bug 23727] Implementaion of WCSS marquee extension relevant to XHML MP

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=23727


Nikolas Zimmermann <zimmermann at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #34648|review?(zimmermann at kde.org) |review+
               Flag|                            |




--- Comment #30 from Nikolas Zimmermann <zimmermann at kde.org>  2009-08-12 06:13:54 PDT ---
(From update of attachment 34648)
Hi Charles,

patch looks great, along with your comments (regarding the impossiblity to
not-hardcode the stuff.)

One last question:

> Index: WebCore/css/WCSSValueKeywords.in
> ===================================================================
> --- WebCore/css/WCSSValueKeywords.in	(revision 0)
> +++ WebCore/css/WCSSValueKeywords.in	(revision 0)
> @@ -0,0 +1 @@
> +# place holder for all WCSS specific CSS value keywords

Do we need this file? I suspect you _may_ need it for the build process?
If not, please remove this file completly, and reupload a patch, then I'll set
"commit-queue +" as well.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.