[Webkit-unassigned] [Bug 27889] [Chromium] RTL autocomplete popup is not layout correctly.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27889





--- Comment #15 from Xiaomei Ji <xji at chromium.org>  2009-08-07 12:28:49 PDT ---
Hi Eric,

Thanks for your review!

(In reply to comment #14)
> (From update of attachment 34240 [details])
> This constructor will run at library load time and slow down Chromium's launch
> time:
> +static const String kEllipses = "...";

changed to use string literal locally (instead of using static const char*).


> 
> Style violation:
>  55             : label(label), type(type), yOffset(0), ellipsesWidth(0) { }
> 
> Style:
>  349         if ( totalWidth > width)
> 
> Style violations, no argument names when not needed:
>  410         void drawBidiTextWithinWidth(const Font& font, const TextRun& run,
> const FloatPoint& point, int width);

Done the style changes. Unfortunately, check-webkit-style can not catch them.


> 
> I don't think I can actually review the code here.  I would need to study these
> files more.  r- for the style stuff.  Make sure to run check-webkit-style if
> you haven't already. :)

I guess mitz could review the changes in GraphicsContext.
Jay (jcampan) probably could review the changes in PopupMenuChromium. Not sure
whether Jay is webkit reviewer. But he is probably familiar with this piece of
code, and I could certainly use his comments.

Thanks,
Xiaomei

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.