[Webkit-unassigned] [Bug 27889] [Chromium] RTL autocomplete popup is not layout correctly.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27889


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #34240|review?                     |review-
               Flag|                            |




--- Comment #14 from Eric Seidel <eric at webkit.org>  2009-08-06 18:40:02 PDT ---
(From update of attachment 34240)
This constructor will run at library load time and slow down Chromium's launch
time:
+static const String kEllipses = "...";

Style violation:
 55             : label(label), type(type), yOffset(0), ellipsesWidth(0) { }

Style:
 349         if ( totalWidth > width)

Style violations, no argument names when not needed:
 410         void drawBidiTextWithinWidth(const Font& font, const TextRun& run,
const FloatPoint& point, int width);

I don't think I can actually review the code here.  I would need to study these
files more.  r- for the style stuff.  Make sure to run check-webkit-style if
you haven't already. :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.