[Webkit-unassigned] [Bug 26988] Haiku-specific files for WebCore

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26988


David Levin <levin at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #32875|review?                     |review-
               Flag|                            |




--- Comment #53 from David Levin <levin at chromium.org>  2009-08-07 10:05:06 PDT ---
(From update of attachment 32875)
Here are some other things to fix up in the code.  I gave examples in places
but the whole patch should be examined for the issues.

Needs a check-webkit-style pass.


Also, look at spacing. There are several places. Here's an example:
      110         BView*    view=i.context->platformContext();
      No spaces around =.  To much space after BView* (actually it may be a
TAB).

    112         if (isEnabled( o )) {
    No spaces to the left of ( or to the right of ).


Odd indentation:
    170               
view->SetHighColor(tint_color(ui_color(B_KEYBOARD_NAVIGATION_COLOR),
    179                     B_DISABLED_MARK_TINT));
  Typically indented to the nested ( on the previous line.

    182                     // needed because of anti-aliasing
  The comment should be aligned with the code and be formed like a sentence
(starting with a capital and ending with a period).
    183                 view->StrokeLine(BPoint(rect.left, rect.top),


Variable names should be words.  Example: "const RenderObject::PaintInfo& i" 


" //code taken from the Haiku source code (CheckBox.cpp)"
What is the license on the Haiku source?  Does it need to be added to the file
and is it WebKit compatible?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.