[Webkit-unassigned] [Bug 26988] Haiku-specific files for WebCore

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26988





--- Comment #52 from Maxime Simon <simon.maxime at gmail.com>  2009-08-07 08:26:18 PDT ---
> > +static String keyIdentifierForHaikuKeyCode(char singleByte, int32 keyCode)
> 
> Are you sure you want to use the type "int32" here? We'd normally use int, or
> perhaps int32_t. Is this something specific to the Haiku platform?
> 

int32 is indeed a specific int type of Haiku. I change it to int.

> > +    m_deltaX *= -static_cast<float>(cScrollbarPixelsPerLineStep);
> > +    m_deltaY *= -static_cast<float>(cScrollbarPixelsPerLineStep);
> 
> Is the cast to float needed? What effect does it have? I'd expect this to work
> perfectly without the cast.
> 

The cast isn't necessary, even if cScrollbarPixelsPerLineStep is an int.
Anyway, other ports do this cast. (I removed it in this patch.)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.