[Webkit-unassigned] [Bug 27966] Race condition in the database code

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 7 08:51:02 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=27966





--- Comment #7 from Eric Seidel <eric at webkit.org>  2009-08-07 08:50:59 PDT ---
(From update of attachment 34241)
Style violation:
48         virtual void aquireLock(SQLTransaction* transaction);
 49         virtual void releaseLock(SQLTransaction* transaction);

I've looked again.  This is simply too big for me to review.  You might be able
to find one of the Database guys who can do this for you though.  In the
future, definitely try to make your patches smaller by not including
code-cleanup in functional changes.  I suggest you try to track down one of the
folks who have worked on storage via IRC.  Failing that, r- the patch and
re-post a smaller piece.  I assume that it's not possible to land the layout
test first since it will cause DRT to hang?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list