[Webkit-unassigned] [Bug 27426] adding GDOMBinding.cpp/h as part of GObject bindings

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27426





--- Comment #6 from Luke Kenneth Casson Leighton <lkcl at lkcl.net>  2009-08-07 02:48:47 PDT ---
(In reply to comment #5)
> (From update of attachment 33972 [details])
> Bunch of Style violations.
> 
> Please don't post patches with #if 0 code.

 mmm... the job of the next person who works on this will be made that much
harder if that code is removed.  with the #if 0 all they need do is go, "oh,
that's all i need to do, remove the #if 0".

without the #if 0 they will go, "wtf am i supposed to be doing?  err, where did
this file come from originally, oh, it was cut/paste together from a ton of
JSBinding files, where are those, err, what's the difference between this file
and that one"....

so, to save someone a lot of hassle, what is the best procedure to leave code
in that will make peoples' lives a lot easier [e.g. when adding SVG Canvas]


> There are a billion includes in this file.  maybe we should split some of this
> out into separate files?

 mmm... yehhh.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.