[Webkit-unassigned] [Bug 27756] [HTML5][Forms] Part 2 of datalist&list: Support for HTMLInputElement::list and HTMLInputElement::selectedOption

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 6 20:53:09 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=27756





--- Comment #10 from TAMURA, Kent <tkent at chromium.org>  2009-08-06 20:53:08 PDT ---
(In reply to comment #9)

Thanks for the comment.

> (From update of attachment 33863 [details])
> This is not safe:
>  1811     RefPtr<HTMLCollection> options =
> static_cast<HTMLDataListElement*>(sourceElement)->options();
> (at least not if we add more list() types).  I think until we add more list()
> types we could just make it return HTMLDataListElement*.  But checking at each
> callsite is OK too.

Ok, will do.

> Seems this needs to be guarded by DATAGRID defines, no?  Or do we have a
> DataList?  This doesn't look like a complete implementation, or?

This patch is not related to datagird though the part 1 (#26915) is.  I think
it is reasonable to guard by another flag such as ENABLE(INPUT_LIST).

I'll update the patch after the part 1 is landed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list