[Webkit-unassigned] [Bug 27756] [HTML5][Forms] Part 2 of datalist&list: Support for HTMLInputElement::list and HTMLInputElement::selectedOption

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27756


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #33863|review?                     |review-
               Flag|                            |




--- Comment #9 from Eric Seidel <eric at webkit.org>  2009-08-06 19:29:29 PDT ---
(From update of attachment 33863)
This is not safe:
 1811     RefPtr<HTMLCollection> options =
static_cast<HTMLDataListElement*>(sourceElement)->options();
(at least not if we add more list() types).  I think until we add more list()
types we could just make it return HTMLDataListElement*.  But checking at each
callsite is OK too.

Seems this needs to be guarded by DATAGRID defines, no?  Or do we have a
DataList?  This doesn't look like a complete implementation, or?

I can't remember if you're a committer yet or not.  so r- assuming you'll need
someone else to land after you fix those nits.

This doesn't seem very useful w/o UI... but this is OK to land for now if it's
guarded by and ENABLE.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.