[Webkit-unassigned] [Bug 27984] cpp_style.py lacks checks for pointer and reference declaration style.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27984


David Levin <levin at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #34072|review?                     |review-
               Flag|                            |




--- Comment #3 from David Levin <levin at chromium.org>  2009-08-04 11:08:42 PDT ---
(From update of attachment 34072)
This needs unit tests (added to cpp_style_unittests.py)

Also, you could combine the regex and put them in a (named) group and then use
the result from the group in the printed error message.

Lastly, this guideline only applies to C++ code.  The tool also runs on C files
and the guideline is reversed in that case.  (int *i;)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.