[Webkit-unassigned] [Bug 27984] cpp_style.py lacks checks for pointer and reference declaration style.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27984


Mike Fenton <mike.fenton at torchmobile.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #34072|0                           |1
        is obsolete|                            |
  Attachment #34137|                            |review?
               Flag|                            |




--- Comment #4 from Mike Fenton <mike.fenton at torchmobile.com>  2009-08-05 08:39:17 PDT ---
Created an attachment (id=34137)
 --> (https://bugs.webkit.org/attachment.cgi?id=34137)
Updated patch for cpp_style validation of pointer / references.

Patch has been updated with the following chanages.

1) Add unit tests.
2) Update unit test for c style cast to be processed as c style code (ie. don't
complain about the int *b)
3) Divide logic for C/C++ validation to properly support each style.
4) Tighten up logic of regex to compare to beginnings of lines only (greatly
reduces false matches)
5) Add extra check for references to avoid return &variable; matching.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.