[Webkit-unassigned] [Bug 25347] Add a FrameLoaderClient callback for the ResourceRetrievedByXMLHttpRequest.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25347





------- Comment #12 from pfeldman at chromium.org  2009-04-29 12:06 PDT -------
(In reply to comment #10)
> (From update of attachment 29714 [review])
> +        virtual void dispatchResourceRetrievedByXMLHttpRequest(unsigned long,
> const WebCore::ScriptString&);
> 
> The name for this function does not match other client functions.
> 
> Something like this would fit better:
> 
> dispatchDidLoadResourceByXMLHttpRequest
> 
> +        void resourceRetrievedByXMLHttpRequest(unsigned long identifier, const
> ScriptString& sourceString);
> 
> This should be renamed to something that matches too. Maybe:
> 
> didLoadResourceByXMLHttpRequest
> 

Done. Thanks for the review!


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.