[Webkit-unassigned] [Bug 20953] Rework the Font handling in QtWebKit
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Sep 23 04:16:33 PDT 2008
https://bugs.webkit.org/show_bug.cgi?id=20953
------- Comment #12 from eric at webkit.org 2008-09-23 04:16 PDT -------
(From update of attachment 23594)
This seems sane enough to me. This is great to see the Qt port's font code
aligning more with the other ports.
There are a few style violations in this patch (mostly * and & spacing
inconsistent with the WebKit style guidelines). There are also a bunch of //
qtDebug() comments. We generally don't commit commented out code, so I would
encourage you to remove those.
This patch of course depends on the other two, which I feel hyatt or mitz are
much more capable of reviewing than I.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
More information about the webkit-unassigned
mailing list