[Webkit-unassigned] [Bug 20953] Rework the Font handling in QtWebKit

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=20953


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #23591|review?                     |review+
               Flag|                            |




------- Comment #11 from darin at apple.com  2008-09-21 11:32 PDT -------
(From update of attachment 23591)
This code in WidthIterator was all Apple-written in 2003, and didn't come from
KHTML, so you don't need to include the pre-2003 copyrights on the new file.

+/**
+ * This file is part of the html renderer for KDE.

You shouldn't copy those lines either.

+        private:
+        UChar32 normalizeVoicingMarks(int currentCharacter);

Indentation here is wrong. the private should be outdented.

+#include "Font.h"

I don't think we really need to include the entire Font.h header. This file
just declares things, it doesn't actually need class definitions for classes
like Font and TextRun. All we need is a forward delcaration of Font,
GlyphBuffer, and TextRun, and then an appropriate include to get the UChar32
type.

WidthIterator should inherit from Noncopyable.

+        WidthIterator(const Font* font, const TextRun& run);
+
+        void advance(int to, GlyphBuffer* glyphBuffer = 0);
+        bool advanceOneCharacter(float& width, GlyphBuffer* glyphBuffer = 0);

Style says we shouldn't have named arguments for font, run, and glyphBuffer.

r=me, but some of those changes should be done, i think.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.