[Webkit-unassigned] [Bug 20287] [Gtk] disable plugins for gtk/directfb target

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=20287





------- Comment #3 from jmalonzo at gmail.com  2008-09-22 06:08 PDT -------
(In reply to comment #2)
> (From update of attachment 23620 [edit])
> Substance:
>   - Is GDK_WINDOWING_X11 really defined when building for Gtk+/X11? Is that due
> a broken pc file?

It is defined in gdkconfig.h, which you get when you install the "gtk-dev"
package.

> 
>   - Your patch is changing a lot more than advertised. Change the summary or
> split it up.

Ok. I'll update the summary.

> 
>   - We added cairo-ft for a specific reason, we have to figure out if that
> reason is gone

It was ok to keep it there but looking into it more, I don't think we need it
anymore for two reasons: 

1. It assumes an X11-based cairo, which means we don't get enough value out of
it when we build with directfb

2. cairo.pc already contains what cairo-ft can provide us.

> 
>    - Adding a random directory to cppflags is quite "dangerous", people with
> broken packages could just do CPPFLAGS=-I/right/dir ./configure. Specially when
> cross compiling we might pick up the wrong headers.

Thanks. I don't think we need this line anymore. I added it because I thought
I'm going to need GDK_WINDOWING_DIRECTB. But this should come from the .pc file
(which is not there atm).

> 
> Style:
>    - #define WTF_USE_BLA 1 is supposed to be used in a #if USE(BLA) way.

Ok. I changed this and add WTF_PLATFORM_X11 instead and add the check along
with GDK_WINDOWING_X11 (e.g. GDK_WINDOWING_X11 && PLATFORM(X11)). The reason
being is that some systems (e.g. Debian) allow gtk X11 packages and directfb
packages installed side-by-side. Therefore checking for GDK_WINDOWING_X11 is
not enough to determine an X11 (or non-X11) build.

I hope that answers your questions. 

Thanks and appreciate your feedback.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.