[Webkit-unassigned] [Bug 20287] [Gtk] disable plugins for gtk/directfb target

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=20287


freyther at handhelds.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #23620|review?                     |review-
               Flag|                            |




------- Comment #2 from freyther at handhelds.org  2008-09-21 19:21 PDT -------
(From update of attachment 23620)
Substance:
  - Is GDK_WINDOWING_X11 really defined when building for Gtk+/X11? Is that due
a broken pc file?

  - Your patch is changing a lot more than advertised. Change the summary or
split it up.

  - We added cairo-ft for a specific reason, we have to figure out if that
reason is gone

   - Adding a random directory to cppflags is quite "dangerous", people with
broken packages could just do CPPFLAGS=-I/right/dir ./configure. Specially when
cross compiling we might pick up the wrong headers.

Style:
   - #define WTF_USE_BLA 1 is supposed to be used in a #if USE(BLA) way.


And I agree that plugins should/can currently only be build on Gtk+/X11.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.