[Webkit-unassigned] [Bug 21816] Clean up ImageBuffer.h so there do not have to be separate ifdefs for each platform

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=21816


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |darin at apple.com




------- Comment #15 from darin at apple.com  2008-10-27 14:29 PDT -------
(In reply to comment #13)
> Maybe I missed what you were suggesting. You're suggesting that we kill
> create() and have ImageBuffer have an out parameter that indicates success to
> the callers?

No, I wasn't suggesting that. Sorry, forgot to cc myself on the message.

I was suggesting that we keep create exactly as it was before, with
platform-specific versions as necessary. The create function itself would
return 0 if it failed.

My alternate suggestion, if you really feel that create needs to become
cross-platform, would be to use an out parameter for the boolean success flag,
making ImageBuffer constructors able to indicate failure uniformly at
construction time without having to carry that state along for the rest of
their lifetimes.

I'm sorry I didn't see this *before* you made a new patch. My fault entirely
for not cc'ing myself on the bug!


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.