[Webkit-unassigned] [Bug 21816] Clean up ImageBuffer.h so there do not have to be separate ifdefs for each platform

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=21816


brettw at chromium.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24695|                            |review?
               Flag|                            |




------- Comment #14 from brettw at chromium.org  2008-10-27 14:25 PDT -------
Created an attachment (id=24695)
 --> (https://bugs.webkit.org/attachment.cgi?id=24695&action=view)
Patch v3

The implements Darin's suggestion of deleting the ::create function and making
the constructor use an out parameter. I had to change a lot of callers, some of
which improved in clarity, some of which got slightly worse as a result of this
change. The code in ImageBuffer*.cpp is much shorter.

This adds a one-line ifdef change to allow Skia ports to implement text drawing
modes (the change in GraphicsContext.cc).


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.